bruig: show file type icon and open file on click #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. One thing, I'm not seeing any difference of cursor when hovering the Icon. Was thinking you could add a similar splash radius to the IconButton like we do for the AppBar icons within overview.dart. But definitely something to let the user know that they can click to open would be ideal. |
|
Also was thinking once this is merged, you can apply the same design/mechanics to the Show Content user action and the Manage Content / Shared & Downloads pages |
miki-totefu
approved these changes
Apr 11, 2023
|
needs rebase fix |
tiagoalvesdulce
force-pushed
the
file_icon
branch
from
aacbe9a
to
ac69c64
Compare
tiagoalvesdulce
force-pushed
the
file_icon
branch
from
ac69c64
to
4d5bd90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
Clicking the icon will launch the file.
Closes #32