bruig: remove newline added on <enter> and don't submit empty msgs #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoalvesdulce
changed the title
miki-totefu
approved these changes
Apr 11, 2023
alexlyp
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
I came up with a simple workaround to fix the issue where I remove the newline added by the TextFIeld when is pressed.
I think in the future we should move the
RawKeyboardListeneronKeyhandler to the onKeyEvent property of theeditLineFocusNode. I played with this a little but it would require lifting some state up the Widget tree or passing a function from child to parent (which sounds weird). Suggestions are welcome.While doing this I noticed I could send empty messages so this PR also prevents that.