client: parallel push RMs #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 19, 2023 14:01
This modifies the client DB implementation to keep track of multiple unacked RMs per user, instead of a single one. This will be necessary in the future to handle failures when sending multiple concurrent RMs.
This function returns the status about a previous payment attempt.
This reads and exposes the recently introduced props that control parallel RM push from the server.
This adds functions to the clientdb to allow the client to store the payment status for unacked RMs. This will be necessary to handle restart cases during parallel RM pushing.
The ID will have to be sent when sending multiple concurrent RMs. For the free client, the ID is derived from the passed invoice to help with tests.
This DB will be necessary for the RMQ to track unacked RMs that have been paid for across client restarts.
This adds support in the RMQ for parallel sending of RMs to the server. The status of a paid RM is stored in the DB, and the corresponding invoice ID is sent to the server together with the RM data. Tests are added to verify the new behavior.
miki-totefu
force-pushed
the
clientparallelsend
branch
2 times, most recently
from
ff3b3c9
to
dfd1cfc
Compare
dajohi
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the client side of #97: payment and pushes to the server are done in parallel for multiple RMs without waiting for server ack.
this can't be used in production until the production server is updated to use it.