Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive materials class #22

Closed
ioannaMitropoulou opened this issue Oct 8, 2020 · 0 comments
Closed

Archive materials class #22

ioannaMitropoulou opened this issue Oct 8, 2020 · 0 comments
Assignees

Comments

@ioannaMitropoulou
Copy link
Collaborator

Archive materials and cleanup.

"""
hey @ioanna Mitropoulou something else: I was thinking it might make sense to also remove the MachineModel and the Material classes for now, since we are not really using them. In the example we are just calling them but then we are not using them.

--- Fabrication

robot_printer = RobotPrinter('UR5')
material_PLA = Material('PLA')
I think maybe in general we might not need 'Material' since I think often users want to set their own print speed, temperature etc. anyway and not use standard values, since robotic printing is not a standard process anyway. We can have some standard values but imo they don't have to rely on different materials.
Then as for robot models, I think for now our export is still general enough to be used by any kind of robot right? Sure we are focusing on UR's, but currently we are not yet changing something to make it only UR specific. I think at the current moment, compas_slicer is also more of a general slicing tool, which then allows the user to pick their favorite robot and command generation tool, right?
"""

@ioannaMitropoulou ioannaMitropoulou self-assigned this Oct 8, 2020
@ioannaMitropoulou ioannaMitropoulou moved this from To do to In progress in Preparation for MAS T1 Oct 8, 2020
@ioannaMitropoulou ioannaMitropoulou moved this from In progress to Done in Preparation for MAS T1 Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant