Skip to content
This repository has been archived by the owner on Apr 24, 2019. It is now read-only.

jannovar should be updated #335

Open
jvlasblom opened this issue Jun 18, 2014 · 2 comments
Open

jannovar should be updated #335

jvlasblom opened this issue Jun 18, 2014 · 2 comments
Assignees

Comments

@jvlasblom
Copy link

Jannovar has had several updates posted on the git repository https://github.com/charite/jannovar.git

(This is Peter Robinson's repository, we don't have/want write access to it).

We've absorbed the Jannovar source code as a subproject of medsavant (in subdir medsavant/jannovar) as of late-march. The changes posted to https://github.com/charite/jannovar.git since then should be merged in with our own changes.

@meatcar
Copy link
Contributor

meatcar commented Jul 4, 2014

What really should be done, is Jannovar should be forked under the compbio-UofT organization, and that fork should be used either as a git submodule, or a maven dependency when building medsavant. That way, any changes we make to Jannovar could be potentially pushed upstream (i.e. logging) via pull requests, while updates upstream can be easily merged into our version.

@meatcar
Copy link
Contributor

meatcar commented Jul 9, 2014

Jannovar has forked to https://github.com/compbio-UofT/jannovar, Changes in the jannovar folder have been added to the fork as individual commits.

Next Steps:

  • Fix Jenkins build (Build Status)
  • Remove jannovar folder from MedSavant source
  • Add compbio-UofT/jannovar as a maven dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants