Bugfix Map usage (#4265)

compiler-explorer · Nov 9, 2022 · 17a56af · 17a56af
1 parent d41eb5c
commit 17a56af
Show file tree

Hide file tree

Showing 18 changed files with 1,064 additions and 59 deletions.
diff --git a/lib/parsers/asm-parser-cc65.ts b/lib/parsers/asm-parser-cc65.ts
@@ -77,7 +77,7 @@ export class CC65AsmParser extends AsmParser {
             return {asm: [{text: asmLines[0], source: null}]};
         }
 
-        const labelDefinitions: Map<string, number> = new Map<string, number>();
+        const labelDefinitions: Record<string, number> = {};
 
         for (const line of asmLines) {
             let match = line.match(this.commentRe);

diff --git a/lib/parsers/asm-parser-spirv.ts b/lib/parsers/asm-parser-spirv.ts
@@ -98,7 +98,7 @@ export class SPIRVAsmParser extends AsmParser {
         const endTime = process.hrtime.bigint();
         return {
             asm: asm,
-            labelDefinitions: new Map<string, number>(),
+            labelDefinitions: {},
             parsingTime: ((endTime - startTime) / BigInt(1000000)).toString(),
             filteredCount: startingLineCount - asm.length,
         };

diff --git a/lib/parsers/asm-parser.ts b/lib/parsers/asm-parser.ts
@@ -333,7 +333,7 @@ export class AsmParser extends AsmRegex {
         }
 
         const asm: ParsedAsmResultLine[] = [];
-        const labelDefinitions: Map<string, number> = new Map<string, number>();
+        const labelDefinitions: Record<string, number> = {};
 
         let asmLines = utils.splitLines(asmResult);
         const startingLineCount = asmLines.length;
@@ -598,7 +598,7 @@ export class AsmParser extends AsmRegex {
     processBinaryAsm(asmResult, filters): ParsedAsmResult {
         const startTime = process.hrtime.bigint();
         const asm: ParsedAsmResultLine[] = [];
-        const labelDefinitions: Map<string, number> = new Map<string, number>();
+        const labelDefinitions: Record<string, number> = {};
         const dontMaskFilenames = filters.dontMaskFilenames;
 
         let asmLines = asmResult.split('\n');

diff --git a/test/filters-cases/bug-1285.asm.none.approved.txt b/test/filters-cases/bug-1285.asm.none.approved.txt
diff --git a/test/filters-cases/eigen-test.asm.none.approved.txt b/test/filters-cases/eigen-test.asm.none.approved.txt
diff --git a/test/filters-cases/gcc-x86-vector.asm.none.approved.txt b/test/filters-cases/gcc-x86-vector.asm.none.approved.txt
diff --git a/test/filters-cases/intsize.asm b/test/filters-cases/intsize.asm
diff --git a/test/filters-cases/intsize.asm.binary.directives.labels.comments.approved.txt b/test/filters-cases/intsize.asm.binary.directives.labels.comments.approved.txt
diff --git a/test/filters-cases/intsize.asm.directives.approved.txt b/test/filters-cases/intsize.asm.directives.approved.txt
diff --git a/test/filters-cases/intsize.asm.directives.comments.approved.txt b/test/filters-cases/intsize.asm.directives.comments.approved.txt