Skip to content

Commit

Permalink
store compilationOptions so that we can debug buildsteps better (#4288)
Browse files Browse the repository at this point in the history
  • Loading branch information
partouf committed Nov 13, 2022
1 parent 423be5b commit 189d445
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions lib/base-compiler.ts
Expand Up @@ -31,6 +31,7 @@ import _ from 'underscore';

import {
BuildResult,
BuildStep,
CompilationCacheKey,
CompilationInfo,
CompilationResult,
Expand Down Expand Up @@ -1882,9 +1883,10 @@ export class BaseCompiler {
};
}

async doBuildstepAndAddToResult(result, name, command, args, execParams) {
const stepResult = {
async doBuildstepAndAddToResult(result, name, command, args, execParams): Promise<BuildStep> {
const stepResult: BuildStep = {
...(await this.doBuildstep(command, args, execParams)),
compilationOptions: args,
step: name,
};
logger.debug(name);
Expand Down
3 changes: 2 additions & 1 deletion types/compilation/compilation.interfaces.ts
Expand Up @@ -129,10 +129,11 @@ export type ExecutionOptions = {
export type BuildResult = CompilationResult & {
downloads: BuildEnvDownloadInfo[];
executableFilename: string;
compilationOptions: any[];
compilationOptions: string[];
};

export type BuildStep = BasicExecutionResult & {
compilationOptions: string[];
step: string;
};

Expand Down

0 comments on commit 189d445

Please sign in to comment.