Fix #4931 and #2218 (#5706)

compiler-explorer · Nov 11, 2023 · 31bd479 · 31bd479
1 parent a1d8570
commit 31bd479
Show file tree

Hide file tree

Showing 82 changed files with 2,886 additions and 196 deletions.
diff --git a/lib/parsers/asm-parser.ts b/lib/parsers/asm-parser.ts
@@ -612,7 +612,10 @@ export class AsmParser extends AsmRegex implements IAsmParser {
             }
             if (match) {
                 // It's a label definition.
-                if (labelsUsed[match[1]] === undefined) {
+
+                // g-as shows local labels as eg: "1:  call  mcount". We characterize such a label as
+                // "the label-matching part doesn't equal the whole line" and treat it as used.
+                if (labelsUsed[match[1]] === undefined && match[0] === line) {
                     // It's an unused label.
                     if (filters.labels) {
                         continue;

diff --git a/test/filters-cases/avr-loop.asm.directives.approved.txt b/test/filters-cases/avr-loop.asm.directives.approved.txt
diff --git a/test/filters-cases/avr-loop.asm.directives.comments.approved.txt b/test/filters-cases/avr-loop.asm.directives.comments.approved.txt
diff --git a/test/filters-cases/avr-loop.asm.directives.labels.approved.txt b/test/filters-cases/avr-loop.asm.directives.labels.approved.txt
diff --git a/test/filters-cases/avr-loop.asm.directives.labels.comments.approved.txt b/test/filters-cases/avr-loop.asm.directives.labels.comments.approved.txt
diff --git a/test/filters-cases/avr-loop.asm.directives.labels.comments.library.approved.txt b/test/filters-cases/avr-loop.asm.directives.labels.comments.library.approved.txt
diff --git a/...ters-cases/avr-loop.asm.directives.labels.comments.library.dontMaskFilenames.approved.txt b/...ters-cases/avr-loop.asm.directives.labels.comments.library.dontMaskFilenames.approved.txt
diff --git a/test/filters-cases/avr-loop.asm.directives.library.approved.txt b/test/filters-cases/avr-loop.asm.directives.library.approved.txt
diff --git a/test/filters-cases/avr-loop.asm.none.approved.txt b/test/filters-cases/avr-loop.asm.none.approved.txt
diff --git a/test/filters-cases/bug-577_icc.asm.directives.approved.txt b/test/filters-cases/bug-577_icc.asm.directives.approved.txt
diff --git a/test/filters-cases/bug-577_icc.asm.directives.comments.approved.txt b/test/filters-cases/bug-577_icc.asm.directives.comments.approved.txt
diff --git a/test/filters-cases/bug-577_icc.asm.directives.labels.approved.txt b/test/filters-cases/bug-577_icc.asm.directives.labels.approved.txt
diff --git a/test/filters-cases/bug-577_icc.asm.directives.labels.comments.approved.txt b/test/filters-cases/bug-577_icc.asm.directives.labels.comments.approved.txt