Skip to content

Commit

Permalink
Use double quotes for embed iframes (#4592)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremy-rifkin authored and mattgodbolt committed Jan 24, 2023
1 parent 62cc8ca commit 58b947e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion static/sharing.ts
Expand Up @@ -391,7 +391,8 @@ export class Sharing {

private static getEmbeddedHtml(config, root, isReadOnly, extraOptions): string {
const embedUrl = Sharing.getEmbeddedUrl(config, root, isReadOnly, extraOptions);
return `<iframe width='800px' height='200px' src='${embedUrl}'></iframe>`;
// The attributes must be double quoted, the full url's rison contains single quotes
return `<iframe width="800px" height="200px" src="${embedUrl}"></iframe>`;
}

private static getEmbeddedUrl(config: any, root: string, readOnly: boolean, extraOptions: object): string {
Expand Down

0 comments on commit 58b947e

Please sign in to comment.