Skip to content

Commit

Permalink
Add dev favicon (#4598)
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremy-rifkin committed Jan 16, 2023
1 parent acc19d1 commit 6e2e98b
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 2 deletions.
14 changes: 13 additions & 1 deletion app.js
Expand Up @@ -181,6 +181,18 @@ if (defArgs.suppressConsoleLog) {

const isDevMode = () => process.env.NODE_ENV !== 'production';

function getFaviconFilename() {
if (isDevMode()) {
return 'favicon-dev.ico';
} else if (opts.env.includes('beta')) {
return 'favicon-beta.ico';
} else if (opts.env.includes('staging')) {
return 'favicon-staging.ico';
} else {
return 'favicon.ico';
}
}

const propHierarchy = [
'defaults',
defArgs.env,
Expand Down Expand Up @@ -776,7 +788,7 @@ async function main() {
res.set('Content-Type', 'application/xml');
res.render('sitemap');
})
.use(sFavicon(utils.resolvePathFromAppRoot('static', 'favicon.ico')))
.use(sFavicon(utils.resolvePathFromAppRoot('static/favicons', getFaviconFilename())))
.get('/client-options.js', (req, res) => {
staticHeaders(res);
res.set('Content-Type', 'application/javascript');
Expand Down
Binary file removed static/favicon.ico
Binary file not shown.
Binary file added static/favicons/favicon-beta.ico
Binary file not shown.
Binary file added static/favicons/favicon-dev.ico
Binary file not shown.
Binary file added static/favicons/favicon-staging.ico
Binary file not shown.
Binary file added static/favicons/favicon-suspend.ico
Binary file not shown.
Binary file added static/favicons/favicon.ico
Binary file not shown.
2 changes: 1 addition & 1 deletion webpack.config.esm.js
Expand Up @@ -92,7 +92,7 @@ const plugins = [
'window.PRODUCTION': JSON.stringify(!isDev),
}),
new CopyWebpackPlugin({
patterns: [{from: './static/favicon.ico', to: path.resolve(distPath, 'static', 'favicon.ico')}],
patterns: [{from: './static/favicons', to: path.resolve(distPath, 'static', 'favicons')}],
}),
];

Expand Down

0 comments on commit 6e2e98b

Please sign in to comment.