Cmake build with ninja (#4287)

compiler-explorer · Jan 24, 2023 · 8ffef81 · 8ffef81
1 parent 209d662
commit 8ffef81
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/etc/config/compiler-explorer.amazon.properties b/etc/config/compiler-explorer.amazon.properties
@@ -37,7 +37,7 @@ alwaysResetLdPath=true
 plogConverter=/opt/compiler-explorer/pvs-studio-latest/bin/plog-converter
 
 cmake=/opt/compiler-explorer/cmake/bin/cmake
-make=/usr/bin/make
+useninja=false
 ld=/usr/bin/ld
 readelf=/usr/bin/readelf
 

diff --git a/etc/config/compiler-explorer.defaults.properties b/etc/config/compiler-explorer.defaults.properties
@@ -45,7 +45,7 @@ remoteStorageServer=https://godbolt.org
 compilationEnvTimeoutMs=300000
 
 cmake=cmake
-make=make
+useninja=false
 ld=ld
 readelf=readelf
 

diff --git a/lib/base-compiler.ts b/lib/base-compiler.ts
@@ -2034,7 +2034,14 @@ export class BaseCompiler implements ICompiler {
             const toolchainparam = this.getCMakeExtToolchainParam();
 
             const cmakeArgs = utils.splitArguments(key.backendOptions.cmakeArgs);
-            const fullArgs = [toolchainparam, ...this.getExtraCMakeArgs(key), ...cmakeArgs, '..'];
+            const partArgs: string[] = [toolchainparam, ...this.getExtraCMakeArgs(key), ...cmakeArgs, '..'];
+            let fullArgs: string[] = [];
+            const useNinja = this.env.ceProps('useninja');
+            if (useNinja) {
+                fullArgs = ['-GNinja'].concat(partArgs);
+            } else {
+                fullArgs = partArgs;
+            }
 
             const cmakeStepResult = await this.doBuildstepAndAddToResult(
                 fullResult,
@@ -2056,9 +2063,9 @@ export class BaseCompiler implements ICompiler {
 
             const makeStepResult = await this.doBuildstepAndAddToResult(
                 fullResult,
-                'make',
-                this.env.ceProps('make'),
-                [],
+                'build',
+                this.env.ceProps('cmake'),
+                ['--build', '.'],
                 execParams,
             );
 

diff --git a/lib/compilers/cc65.ts b/lib/compilers/cc65.ts
@@ -126,7 +126,7 @@ export class Cc65Compiler extends BaseCompiler {
 
     override async doBuildstepAndAddToResult(result: CompilationResult, name, command, args, execParams) {
         const stepResult = await super.doBuildstepAndAddToResult(result, name, command, args, execParams);
-        if (name === 'make') {
+        if (name === 'build') {
             const mapFile = path.join(execParams.customCwd, 'map.txt');
             if (await utils.fileExists(mapFile)) {
                 const file_buffer = await fs.readFile(mapFile);