automatically fix old gccdump states (#4641)

compiler-explorer · Jan 25, 2023 · db69a5e · db69a5e
1 parent c803074
commit db69a5e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/static/panes/gccdump-view.ts b/static/panes/gccdump-view.ts
@@ -120,6 +120,15 @@ export class GccDump extends MonacoPane<monaco.editor.IStandaloneCodeEditor, Gcc
         this.eventHub.emit('gccDumpUIInit', this.compilerInfo.compilerId);
     }
 
+    override initializeCompilerInfo(state: Record<string, any>) {
+        super.initializeCompilerInfo(state);
+
+        if (!state.id && state._compilerid) this.compilerInfo.compilerId = state._compilerid;
+        if (!state.editorid && state._editorid) this.compilerInfo.editorId = state._editorid;
+        if (!state.compilerName && state._compilerName) this.compilerInfo.compilerName = state._compilerName;
+        if (!state.treeid && state._treeid) state.treeId = state._treeid;
+    }
+
     override getInitialHTML(): string {
         return $('#gccdump').html();
     }

diff --git a/static/panes/pane.ts b/static/panes/pane.ts
@@ -70,12 +70,7 @@ export abstract class Pane<S> {
 
         this.hideable = this.domRoot.find('.hideable');
 
-        this.compilerInfo = {
-            compilerId: state.id,
-            compilerName: state.compilerName,
-            editorId: state.editorid,
-            treeId: state.treeid,
-        };
+        this.initializeCompilerInfo(state);
         this.topBar = this.domRoot.find('.top-bar');
 
         this.paneRenaming = new PaneRenaming(this, state);
@@ -92,6 +87,15 @@ export abstract class Pane<S> {
         this.registerOpeningAnalyticsEvent();
     }
 
+    protected initializeCompilerInfo(state: Record<string, any>) {
+        this.compilerInfo = {
+            compilerId: state.id,
+            compilerName: state.compilerName,
+            editorId: state.editorid,
+            treeId: state.treeid,
+        };
+    }
+
     /**
      * Get the initial HTML layout for the pane's default content. A typical
      * implementation looks like this: