Truncate error messages

[mattgodbolt]

E.g. putting this code: template<class T>class L{L<T*>operator->()};L<int>i=i-> in the view kills the browser...

[dreamzor]

Here is the more complete list: http://tgceec.tumblr.com/post/74534916370/results-of-the-grand-c-error-explosion

[mattgodbolt]

"Works" on the beta site. Generates a jolly large error message:

$ curl 'https://gcc.godbolt.org/api/compiler/g63/compile?options=-Wall' --data-binary 'template<class T>class L{L<T*>operator->()};L<int>i=i->' | wc
   6292   27269  822287

I think the error message needs truncating a tiny bit earlier.

[mattgodbolt]

Couldn't reproduce (via https://godbolt.org/g/ujv6gi ) though I think truncating the error output is still sensible. Renaming bug and making a feature.

[dwcraig]

I'd be happy to work on this. Is there a preferred length to truncate the error messages to?

[RubenRBS]

I think that the best solution would be to make it configurable via the .properties files, so 3rd party users can set it to match their needs

[dwcraig]

I am able to truncate the error message coming from the compiler response in static/compiler.js, but I am unsure how I would access the property to allow the response length to be configured.
Would it be possible for someone to point me in the right direction?

[jaredwy]

Take a look at the config files in ‘etc/‘ I would drop a new property in the default one and load it as a config option. Have a look at ‘app.js’. It loads the config options there. then use this to truncate the error string.

[dwcraig]

Thanks. The part that I am stuck on is loading it as a config option. Sorry, my comment was unclear. I added truncateErrorMessages=20 to compiler-explorer.defaults.properties. I am not sure where or how I should load that as a config option.

[dwcraig]

Thanks @jaredwy and @RabsRincon. I've got it so that the number of lines can be truncated by the amount set in the .properties files. What would be a good value to set the default to when there is nothing set by a user?

[partouf]

This was truncated on the serverside a long time ago, so this is actually fixed