Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Mac Support / FreeBSD #3

Closed
stevie- opened this issue Jul 29, 2021 · 2 comments · Fixed by #6
Closed

Request: Mac Support / FreeBSD #3

stevie- opened this issue Jul 29, 2021 · 2 comments · Fixed by #6

Comments

@stevie-
Copy link

stevie- commented Jul 29, 2021

Current bash script only works for system with grep which understands perl regex (switch -P)

grep (GNU grep) vs grep (BSD grep)

Maybe switch to egrep patterns?

@ssbarnea
Copy link

Sadly my enthusiasm about having a conventional commit pre-commit (python tool) hook got lost when I seen this bug, which is a blocker.

Did anyone found an alternative? Now I am using a mix of husky with pre-commit but that is bit annoying and I would like to go for a pure pre-commit implementation.

@DanielVoogsgerd
Copy link
Contributor

I created a branch DanielVoogsgerd/conventional-pre-commit@b1c34563d0f31d98b0c8ecae168b56797fdb7d78 that uses extended regular expressions instead of perl regular expressions. However this conflicts with my own issue/pr #5. Once that is merged/rejected I'll open a PR for this one.

This was referenced Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants