Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no run with certain arguments #37

Closed
Dogway opened this issue Nov 8, 2022 · 4 comments
Closed

no run with certain arguments #37

Dogway opened this issue Nov 8, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Dogway
Copy link

Dogway commented Nov 8, 2022

Executing the following:

for %%F in ("%FOLDER%\*.mp3") do (
    rsgain custom -t -I 4 -L -s i -c p -l -18 "%%F"
)

Won't run in Win7 x64 until I remove -t (true peak) and lower tag version to 3 (-I 3).
Also -s doesn't accept e anymore

Old version (2.0.1) works fine:

for %%F in ("%FOLDER%\*.mp3") do (
    rsgain custom -r -k -K -2.0 -s e -d 0.0 -L -S -I 4 "%%F"
)
@complexlogic
Copy link
Owner

Can you post the output? There should be an error message.

@Dogway
Copy link
Author

Dogway commented Nov 9, 2022

No sorry, silent "crash". Is there any verbose mode?

@complexlogic complexlogic added the bug Something isn't working label Nov 9, 2022
@complexlogic
Copy link
Owner

I was able to reproduce this. There is a problem with the ID3v2 version parsing. I fixed it. Could you try out the new build here and let me know if it fixes for you?

The -s e mode was removed because it enabled non-standard tags.

@Dogway
Copy link
Author

Dogway commented Nov 9, 2022

Yes, working great now, I compared both versions and they match Gain and Peak. The only thing it doesn't write RefLoud nor Range. I think they were useful though, specially RefLoud.

EDIT: By the way, an option to keep timestamps would be great.

@Dogway Dogway closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants