Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault (core dumped) on some files #58

Closed
kylxbn opened this issue Apr 12, 2023 · 3 comments
Closed

Segmentation fault (core dumped) on some files #58

kylxbn opened this issue Apr 12, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@kylxbn
Copy link

kylxbn commented Apr 12, 2023

I have been encountering some crashes on a couple of files. I am not sure why these fails, I have verified that the files are not corrupted. Here are a couple of the files that makes rsgain crash.

rsgain-crash.zip

I have a feeling that one of the files is too short (803 milliseconds) but maybe it should just be padded with silence at the end automatically in case it is too short? But for the MP3 file, I have no idea why it crashes.

If I can provide more detail, please tell me.

I am running rsgain 3.2.1 - using:
   libebur128     1.2.6
   libavformat    60.3.100
   libavcodec     60.3.100
   libavutil      58.2.100
   libswresample  4.10.100

Built with:
   taglib         1.13.0

Compiler:         GCC 12.2
Build Date:       Apr  2 2023
@complexlogic
Copy link
Owner

Thanks for the report. I traced this to the the progress bar. If you run with -q, you should notice that it does not crash. The cause is most likely overflow of a buffer that was initialized with zero or invalid size. I will have time to further investigate and provide a fix later this week.

@complexlogic complexlogic added the bug Something isn't working label Apr 12, 2023
@kylxbn
Copy link
Author

kylxbn commented Apr 13, 2023

Awesome! Thank you very much!

@cirdanlunae
Copy link

Thanks for the report. I traced this to the the progress bar. If you run with -q, you should notice that it does not crash. The cause is most likely overflow of a buffer that was initialized with zero or invalid size. I will have time to further investigate and provide a fix later this week.

Thank you so much for posting a workaround. You kept me from scratching my head for hours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants