Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move boolean operations from shape to bool #8

Open
carlos-adir opened this issue May 16, 2024 · 0 comments
Open

Move boolean operations from shape to bool #8

carlos-adir opened this issue May 16, 2024 · 0 comments

Comments

@carlos-adir
Copy link
Contributor

Currently the boolean operation between two shapes is made by FollowPath, which is inside the file shape.py.
The proposition is to move this responsibility to a new file called bool.py.

The main problem is: these functions receives BaseShape entities, Therefore we would have a circular import.
They are used to know if the midpoint of a segment is inside/outside the other shape.

A solution is to create a JordansContainer, like a tuple(tuple(JordanCurve)), that is used as input/output for a boolean operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant