fix(UI): Dependency-Link not shown in side-nav if no dependencies and…

… peerDependencies fix #506
compodoc · Mar 14, 2018 · 5ffe9d2 · 5ffe9d2
1 parent 720667c
commit 5ffe9d2
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 22 deletions.
diff --git a/src/app/engines/html-engine-helpers/or-length.helper.ts b/src/app/engines/html-engine-helpers/or-length.helper.ts
@@ -8,7 +8,7 @@ export class OrLengthHelper implements IHtmlEngineHelper {
         // We start at 1 because of options
         for (let i = 1; i < len; i++) {
             if (typeof arguments[i] !== 'undefined') {
-                if (arguments[i].length > 0) {
+                if (Object.keys(arguments[i]).length > 0) {
                     return options.fn(context);
                 }
             }

diff --git a/src/templates/partials/menu.hbs b/src/templates/partials/menu.hbs
@@ -50,15 +50,15 @@
                         </a>
                     </li>
                 {{/each}}
-                {{#objectLength packageDependencies ">" 0}}
+                {{#orLength packageDependencies packagePeerDependencies}}
                     <li class="link">
                         <a href="{{relativeURL depth pageType 'root'}}dependencies.html"
                             {{#compare name "===" 'dependencies' }} class="active" {{/compare}}
                             >
                             <span class="fa fa-fw fa-list"></span>Dependencies
                         </a>
                     </li>
-                {{/objectLength}}
+                {{/orLength}}
             </ul>
         </li>
 

diff --git a/src/templates/partials/package-dependencies.hbs b/src/templates/partials/package-dependencies.hbs
@@ -1,21 +1,27 @@
-<ol class="breadcrumb">
-    <li>Dependencies</li>
-</ol>
-<ul class="dependencies-list">
-    {{#each packageDependencies}}
-    <li>
-        <b>{{@key}}</b> : {{this}}</li>
-    {{/each}}
-</ul>
+{{#if packageDependencies}}
+    <ol class="breadcrumb">
+        <li>Dependencies</li>
+    </ol>
+    <ul class="dependencies-list">
+        {{#each packageDependencies}}
+        <li>
+            <b>{{@key}}</b> : {{this}}</li>
+        {{/each}}
+    </ul>
+{{/if}}
+
 {{#if packagePeerDependencies}}
-<br/>
-<ol class="breadcrumb">
-    <li>Peer Dependencies</li>
-</ol>
-<ul class="dependencies-list">
-    {{#each packagePeerDependencies}}
-    <li>
-        <b>{{@key}}</b> : {{this}}</li>
-    {{/each}}
-</ul>
+
+    {{#if packageDependencies}}
+    <br/>
+    {{/if}}
+    <ol class="breadcrumb">
+        <li>Peer Dependencies</li>
+    </ol>
+    <ul class="dependencies-list">
+        {{#each packagePeerDependencies}}
+        <li>
+            <b>{{@key}}</b> : {{this}}</li>
+        {{/each}}
+    </ul>
 {{/if}}