Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse("constructor") returns {r:undefined,g:undefined,c:undefined} #7

Open
tolmasky opened this issue May 7, 2015 · 0 comments · May be fixed by #8
Open

parse("constructor") returns {r:undefined,g:undefined,c:undefined} #7

tolmasky opened this issue May 7, 2015 · 0 comments · May be fixed by #8

Comments

@tolmasky
Copy link

tolmasky commented May 7, 2015

It seems that its picking up everything in the prototype. Changing colors[c.toLowerCase()] to if (Object.prototype.hasOwnProperty(colors, c.toLowerCase()) .... should do the trick.
@Me1000 Me1000 linked a pull request Jul 10, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for incorrect color parsing for certain strings. runkit-forks/color-parser
1 participant
@tolmasky