Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

still need aliasing mechanism for .main #141

Closed
tj opened this issue Dec 30, 2013 · 4 comments
Closed

still need aliasing mechanism for .main #141

tj opened this issue Dec 30, 2013 · 4 comments

Comments

@tj
Copy link
Contributor

tj commented Dec 30, 2013

just realized this will break stuff like reactive with lib/index.js and then relative requires. so we either need to rewrite those requires or use aliasing.
@tj
Copy link
Contributor Author

tj commented Dec 30, 2013

kind of wish we forced ./index.js to always be the entry point, no reason not to, if it's anything but that it's usually just unclear or confusing

@bmcmahen
Copy link

agreed. I don't think I have ever not used index.js as main.

@tj
Copy link
Contributor Author

tj commented Dec 30, 2013

fixed in 98e8c4a

but yup haha wish we never added support for main

@tj tj closed this as completed Dec 30, 2013
@micky2be
Copy link
Contributor

Please don't force it to index.js
It will break our apps and our flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tj @micky2be @bmcmahen