Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming require breaks things #47

Closed
azhang opened this issue Apr 12, 2014 · 2 comments
Closed

renaming require breaks things #47

azhang opened this issue Apr 12, 2014 · 2 comments

Comments

@azhang
Copy link
Contributor

azhang commented Apr 12, 2014

var r = require
type = r('type')

Not sure if this is intended behavior, but in this case, r('type') is directly copied over to the output.

However,

type = require('type');

will produce the expected output:

type = require("component~type@1.0.0");

For reference this is from "forbeslindesay~ajax@0.0.2" but since this isn't expected I thought I'd raise the issue here too.

@jonathanong
Copy link
Contributor

yeah more of a docs issue. there's no reason you need to do this though. alternative is to actually parse the JS, but that's when shit gets too complicated.

in the future. you won't be able to rewrite import.

@azhang
Copy link
Contributor Author

azhang commented Apr 16, 2014

Gotcha, cool.

@azhang azhang closed this as completed Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants