Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glyphs are being dropped in our 3d converter #7

Open
johno opened this issue Sep 10, 2021 · 5 comments
Open

Glyphs are being dropped in our 3d converter #7

johno opened this issue Sep 10, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@johno
Copy link
Contributor

johno commented Sep 10, 2021

It was reported that non-latin glyphs are being dropped and result in improper output for typefaces that include other glyphs.

To reproduce, visit the Noto Sans Page and input one of these glyphs.

image

@johno johno added the bug Something isn't working label Sep 10, 2021
@johno johno self-assigned this Sep 10, 2021
@Guillaume-Levrier
Copy link

Thank you for looking into this!

@deanblacc
Copy link
Contributor

It looks like the issue is with OpenType and how it parses certain kinds of .tff fonts, which are mapped using a cmap3 method. Those font are currently still not supported by OpenType.
There are some related issues here and here.

@Guillaume-Levrier
Copy link

Just to make sure I interpret your answer correctly: do you have another way of mapping non-latin chars or are you dropping all such fonts?

@deanblacc
Copy link
Contributor

@Guillaume-Levrier My bad if that wasn't clear. So, we use the OpenType library to parse font data for the glyph paths. OpenType doesn't currently support certain kinds of .ttf and for the moment at least we can only support what OpenType supports.

@Guillaume-Levrier
Copy link

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants