Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize healthcheck definition #25

Open
ndeloof opened this issue Jan 21, 2020 · 1 comment
Open

sanitize healthcheck definition #25

ndeloof opened this issue Jan 21, 2020 · 1 comment

Comments

@ndeloof
Copy link
Collaborator

ndeloof commented Jan 21, 2020

What is the problem you're trying to solve
healthcheck configuration is based on a string list, first item defining the command type (CMD, CMD-SHELL or NONE). This is confusing and error prone.

Describe the solution you'd like
healthcheck test to be deprecated and we introduce support for command, using same syntax as container specification command - either single string (shell) or list (plain command). NONE is redundant with disable
@hangyan
Copy link
Collaborator

hangyan commented Apr 10, 2020

how about http and tcp support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndeloof @hangyan