Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before 2.6.0: Replace ability to ignore vulnerabilities reported by Composer audit with a bypass option instead #11604

Closed
mxr576 opened this issue Aug 30, 2023 · 3 comments · Fixed by #11605
Milestone

Comments

@mxr576
Copy link
Contributor

mxr576 commented Aug 30, 2023

Composer 2.6.0 is planning to introduce a new ignore feature for security advisories reported by composer audit. The original request was raised for this feature in #11298.

Before the implementation was merged the issue got little traction but after it was merged, it got controversial feedback. As you can see from the thread, personally, I am on the side that a feature like this should not exist.

Today, @janmashat came up with a "you can eat the cake but also keep it" type of idea, a different one that I was suggested before with composer audit-changes:

Rather than an "audit.ignored config setting to ignore security advisories" perhaps we could agree on this compromise: "audit.pass config setting to exit(0) for certain security advisories" (but still list them in the console output).

That way, if somebody is reviewing the "audit log" then they won't have to wonder whether some entries are missing.

(Source: #11298 (comment))

@mxr576
Copy link
Contributor Author

mxr576 commented Aug 30, 2023

With this change, the output of composer audit could be always sent to a Slack channel or other platforms and the build would not fail for silenced vulnerabilities. So issues would not be swept under the carpet... and it is always good to see a "No security vulnerability advisories found" message :)

@AlexSkrypnyk
Copy link

I'd like to second this. Information about the packages that did not pass the audit is always useful and can be logged. It is not always possible to patch at the moment's notice and have you builds fail in CI.

@cmlara
Copy link
Contributor

cmlara commented Aug 31, 2023

I will add my vote of support for this change as well.

Overall this appears to still allow those who need an easy method to bypass failures to do so and at the same time retain an audit trail in the execution logs and allow users who may receive a composer file with exemptions present to easily know what vulnerabilities are present.

@Seldaek Seldaek added this to the 2.6 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants