The 'get another view on the problem' message shouldn't suggest impossible commands #11690
Comments
|
Well, technically, this gives you another view of the problem: this error indicates that the root package itself has a requirement forbidding to use this version (which was already there in the other output as |
|
and the case where your own composer.json forbids it is the only case where the other command will fail early instead of running the solver. |
|
It crashes with an [InvalidArgumentException], and without -vvv that's all you see. |
I don't understand how else I'm supposed to upgrade that package? There is currently a root requirement for ^9.5 and I want to now upgrade to ^10.1. How else should I do this? |
|
Well, if you want to update it to 10.1, you need to update your composer.json to change the requirement. |
|
That's not my point with this issue. Composer outputs a message that says 'Try command |
|
IMHO a bit borderline to call it bad advice to try a --dry-run command, but nevertheless I like @fredden's proposal in #11691 as the require gives a different view on the problem and is exception free in this case. I tried reproducing and could, but require does not lead to an installable set in my testbed (no idea if this was considered an installable set in the first place as the report is about the suggestion message, not the dependencies.) @joachim-n can you try with the patches from #11691 / #11692 and share how it looks from your end? |
I think you're still missing my point. It is bad advice to recommend a specific command which will crash. |
|
@joachim-n : Nah, just my opinion. Please apply those specific patches mentioned and report back if they specifically address your point from your point of view and any more commentary you have about those. This would allow me to better help you finding a solution for your issue. |
|
Ok with latest snapshot the why-not command now outputs:
So I'll call this fixed. Thanks everyone |
My
composer.json:{ "name": "drupal/recommended-project", "description": "Project template for Drupal 9 projects with a relocated document root", "type": "project", "license": "GPL-2.0-or-later", "homepage": "https://www.drupal.org/project/drupal", "support": { "docs": "https://www.drupal.org/docs/user_guide/en/index.html", "chat": "https://www.drupal.org/node/314178" }, "repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8" } ], "require": { "composer/installers": "^1.9", "dealerdirect/phpcodesniffer-composer-installer": "*", "drupal/admin_toolbar": "^3.2", "drupal/coder": "^8.3", "drupal/computed_field_plugin": "^1.3", "drupal/core-composer-scaffold": "^9.4", "drupal/core-dev": "^9.4", "drupal/core-recommended": "^9.5", "drupal/ctools": "^4.0", "drupal/devel": "^5.0", "drupal/devel_entity_updates": "^4.1", "drupal/filelog": "^2.1", "drupal/flag": "^4.0@beta", "drupal/module_builder": "^3.24", "drupal/token": "^1.11", "drupal/ultimate_cron": "^2.0@alpha", "drush/drush": "^11.2", "edemeijer/serialize-debugger": "^0.1.4", "kint-php/kint": "^4.2", "phpspec/prophecy-phpunit": "^2" }, "conflict": { "drupal/drupal": "*" }, "minimum-stability": "dev", "prefer-stable": true, "config": { "allow-plugins": { "composer/installers": true, "drupal/core-composer-scaffold": true, "dealerdirect/phpcodesniffer-composer-installer": true }, "sort-packages": true }, "extra": { "drupal-scaffold": { "locations": { "web-root": "web/" } }, "installer-paths": { "web/core": [ "type:drupal-core" ], "web/libraries/{$name}": [ "type:drupal-library" ], "web/modules/contrib/{$name}": [ "type:drupal-module" ], "web/profiles/contrib/{$name}": [ "type:drupal-profile" ], "web/themes/contrib/{$name}": [ "type:drupal-theme" ], "drush/Commands/contrib/{$name}": [ "type:drupal-drush" ], "web/modules/custom/{$name}": [ "type:drupal-custom-module" ], "web/profiles/custom/{$name}": [ "type:drupal-custom-profile" ], "web/themes/custom/{$name}": [ "type:drupal-custom-theme" ] }, "drupal-core-project-message": { "include-keys": [ "homepage", "support" ], "post-create-project-cmd-message": [ "<bg=blue;fg=white> </>", "<bg=blue;fg=white> Congratulations, you’ve installed the Drupal codebase </>", "<bg=blue;fg=white> from the drupal/recommended-project template! </>", "<bg=blue;fg=white> </>", "", "<bg=yellow;fg=black>Next steps</>:", " * Install the site: https://www.drupal.org/docs/8/install", " * Read the user guide: https://www.drupal.org/docs/user_guide/en/index.html", " * Get support: https://www.drupal.org/support", " * Get involved with the Drupal community:", " https://www.drupal.org/getting-involved", " * Remove the plugin that prints this message:", " composer remove drupal/core-project-message" ] } } }Output of
composer diagnose:When I run this command:
I get the following output:
But then this command, as instructed:
produces this output:
And I expected this to happen:
Composer should not tell me to run a command that it then tells me it can't run.
The text was updated successfully, but these errors were encountered: