Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out the whole file rewrite from JsonConfigSource::manipulateJson into a static helper #11708

Open
chx opened this issue Nov 2, 2023 · 1 comment
Open

Factor out the whole file rewrite from JsonConfigSource::manipulateJson into a static helper #11708

chx opened this issue Nov 2, 2023 · 1 comment

Comments

@chx
Copy link
Contributor

chx commented Nov 2, 2023

I wrote https://github.com/chx/drupal-issue-fork/blob/main/src/DrupalIssueForkCommand.php and the writeConfig method is copy-pasted from JsonConfigSource::manipulateJson. Would you accept a PR moving this code into a static helper somewhere, JsonFile maybe?
@Seldaek
Copy link
Member

Seldaek commented Dec 20, 2023

I guess that sounds ok.. Just the hardest bit as usual is naming it ;) But I'd rather keep it as static func on that class where it is tho btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Seldaek @chx and others