VCS is downloaded when they should be updated

[web-dev]

While working on a slow connection I encountered a timeout when composer tried to download the Symfony framework (#476) after doing a little digging, I found that composer was re-cloning the repository each time.

After some digging I found that the cause was https://github.com/composer/composer/blob/master/src/Composer/Installer.php#L174 where install is called rather than update.

[Seldaek]

Did changing install into an update that help at all with your problem? I don't think it would, but I'm curious to know. Also can you please provide an exact reproduce case with composer.json?

[web-dev]

I tried both an install and an update including one with a primed copy of symfony where I actually checked out the origin master copy. I investigated and it seems that the repositories are being re-downloaded each time.

Obviously this isn't the composor.json file for my project, but the issue still occurs with just the following:

{
    "autoload": {
        "psr-0": { "": "src/" }
    },
    "require": {
        "php": ">=5.3.2",
        "symfony/symfony": "2.1.*"
    },
    "config": {
        "bin-dir": "bin"
    },
    "extra": {
        "symfony-app-dir": "app",
        "symfony-web-dir": "web"
    }
}

[Seldaek]

Is this still actual? Please try again with latest version.

[web-dev]

I just ran a self-update and then an install and I now get this:

PHP Fatal error:  Call to undefined method Composer\DependencyResolver\Rule::disabled() in phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php on line 1669
PHP Stack trace:
PHP   1. {main}() /home/josiah/projects/ec/composer.phar:0
PHP   2. require() /home/josiah/projects/ec/composer.phar:15
PHP   3. Composer\Console\Application->run($input = *uninitialized*, $output = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/bin/composer:9
PHP   4. Symfony\Component\Console\Application->run($input = *uninitialized*, $output = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/Console/Application.php:59
PHP   5. Composer\Console\Application->doRun($input = *uninitialized*, $output = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/vendor/symfony/console/Symfony/Component/Console/Application.php:106
PHP   6. Symfony\Component\Console\Application->doRun($input = *uninitialized*, $output = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/Console/Application.php:70
PHP   7. Symfony\Component\Console\Command\Command->run($input = *uninitialized*, $output = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/vendor/symfony/console/Symfony/Component/Console/Application.php:193
PHP   8. Composer\Command\InstallCommand->execute($input = *uninitialized*, $output = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/vendor/symfony/console/Symfony/Component/Console/Command/Command.php:237
PHP   9. Composer\Installer->run() phar:///home/josiah/projects/ec/composer.phar/src/Composer/Command/InstallCommand.php:64
PHP  10. Composer\DependencyResolver\Solver->solve($request = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/Installer.php:211
PHP  11. Composer\DependencyResolver\Solver->runSat($disableRules = *uninitialized*, $installRecommended = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php:1019
PHP  12. Composer\DependencyResolver\Solver->selectAndInstall($level = *uninitialized*, $decisionQueue = *uninitialized*, $disableRules = *uninitialized*, $rule = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php:1760
PHP  13. Composer\DependencyResolver\Solver->setPropagateLearn($level = *uninitialized*, $literal = *uninitialized*, $disableRules = *uninitialized*, $rule = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php:1392
PHP  14. Composer\DependencyResolver\Solver->analyzeUnsolvable($conflictRule = *uninitialized*, $disableRules = *uninitialized*) phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php:1351
PHP  15. Composer\DependencyResolver\Solver->resetSolver() phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php:1601
PHP  16. Composer\DependencyResolver\Solver->enableDisableLearnedRules() phar:///home/josiah/projects/ec/composer.phar/src/Composer/DependencyResolver/Solver.php:1650

Should I be using master?

[Seldaek]

Well, the composer.json above just runs fine for me, so if you have one that reproduces the bug (from a clean install indicate all steps) it would be nice to share it.

[Seldaek]

The rule::disabled error should now be fixed. Can you give me an update on this issues's status?

[web-dev]

@Seldaek as far as I can tell, its resolved. Thanks!