Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "outdated" color semantic #5447

Closed
mbrodala opened this issue Jun 20, 2016 · 6 comments
Closed

Change "outdated" color semantic #5447

mbrodala opened this issue Jun 20, 2016 · 6 comments

Comments

@mbrodala
Copy link
Contributor

The outdated command currently outputs updates in red; if the update is breaking according to semver it is displayed in yellow.

Since red matches the "error" state and yellow the "warning" state, one would expect the less breaking change to be yellow and the definitely breaking change to be red. Thus I think these two colors should be swapped.

What do you think?

@alcohol
Copy link
Member

alcohol commented Jun 20, 2016

I think that would better match expectations indeed.

@Seldaek
Copy link
Member

Seldaek commented Jun 20, 2016

The colors have been picked to match colors used by npm outdated, and they are documented. The point is that updates marked red are more important/urgent as they are easy to do. While the semver-breaking changes in yellow are less relevant as they might require you to update the app.

@Seldaek Seldaek closed this as completed Jun 20, 2016
@mbrodala
Copy link
Contributor Author

OK, so the color reflects the relevance, not necessarily the severity. Gotta keep this in mind unless you change yours. ;-)

@Seldaek
Copy link
Member

Seldaek commented Jun 20, 2016 via email

@c33s
Copy link

c33s commented Apr 5, 2019

basically i understand the decision to match npm but sticking with something semantically wrong only because other system stick to a wrong semantic is maybe not the best choice.

sidenote:
thank you for this awesome project. composer is really a rocksolid application. thank you for all your work.

@ThomasLandauer
Copy link
Contributor

I just suggested to add a "legend" below the output to clarify the meaning of the colors: #9716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants