Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer Status Support for Non-VCS Packages #5500

Closed
tkn98 opened this issue Jul 7, 2016 · 7 comments
Closed

Composer Status Support for Non-VCS Packages #5500

tkn98 opened this issue Jul 7, 2016 · 7 comments
Labels

Comments

@tkn98
Copy link

tkn98 commented Jul 7, 2016

From what I could quickly checked on the command-line, the composer status does not show any changes with non-vcs (git) repositories, is that correct?

If so what would be your feedback about the idea to have some check or flag to verify archived packages as well?

@stof
Copy link
Contributor

stof commented Jul 7, 2016

how would you check whether a file has been edited for packages installed from an archive ?

@tkn98
Copy link
Author

tkn98 commented Jul 7, 2016

Comparing against the files in the archive. I can imagine that requires implementation per archive format.

@stof
Copy link
Contributor

stof commented Jul 7, 2016

And this requires downloading the archive to compare (with the hope that this archive is still in the cache)

@tkn98
Copy link
Author

tkn98 commented Jul 8, 2016

Yes, something along those lines. So this must be a switch as it could result in quite some network cost.

@alcohol
Copy link
Member

alcohol commented Jul 8, 2016

Seems like a huge waste of time to me :-)

Too much effort and complexity for something that holds very little value and will most likely almost never be used.

@alcohol alcohol added the Feature label Jul 8, 2016
@Seldaek
Copy link
Member

Seldaek commented Jul 11, 2016

I agree that it's not really reasonable and not worth implementing. If you want change tracking make sure you use the preferred-install config to force source installs (this can be turned on for some packages/vendors only) :) https://getcomposer.org/doc/06-config.md#preferred-install

@Seldaek Seldaek closed this as completed Jul 11, 2016
@tkn98
Copy link
Author

tkn98 commented Jul 11, 2016

Yes I know about source installs, in my scenario, that's not the context however. Anyway I can see this is plugin material. Thanks for all the feedback and tips again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants