Run composer validate from different commands

[staabm]

As discussed in #5940 (comment) I would like to propose to internally call „composer validate“ from different commands, which can help/should help to find errors caused by invalid composer.json more easily.

I guess it would help in the following commands:

• at the end of composer diagnose
• when composer update/install runs into a error

What do you guys think?

[Seldaek]

• diagnose already does at least a partial schema check in checkComposerSchema
• Factory::createComposer also does a LAX_SCHEMA validation of the schema when loading the composer.json, which applies to all commands. But this only outputs errors, not warnings as that'd be very invasive.

If you wanna do more why not as long as it doesn't nag people needlessly.. I don't think this problem occurs that often tbh but obviously it's hard to tell.

[staabm]

Factory::createComposer also does a LAX_SCHEMA validation of the schema when loading the composer.json, which applies to all commands

is this LAX validation done, because of performance problems or do not all operations require a strict schema?

If you wanna do more why not as long as it doesn't nag people needlessly.. I don't think this problem occurs that often tbh but obviously it's hard to tell.

in the regular used commands like composer install/update I would only add this additional check in case of errors, so the regular happy path shouldn't see any more errors/warnings then before. at least this would be the goal.

[Seldaek]

Lax just means this:

            $schemaData->additionalProperties = true;
            $schemaData->required = array();

So we don't check for typo in top level property names, and we don't force name to be present. It's not that big a difference.

[stof]

note that composer validate performs more validation than only the schema validation.

[Seldaek]

Closing as IMO doing a full validate is probably overkill, but we have narrowed down the schema quite a bit, and do validate composer.json + auth.json now, and also load the root package with a validating array loader which does 90% of validate command stuff.

[staabm]

Thanks 🙏