Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "~" version constraint operator for projects that use Semantic Versioning. #968

Closed
wants to merge 5 commits into from

Conversation

jmalloc
Copy link
Contributor

@jmalloc jmalloc commented Aug 2, 2012

This PR provides support for a new version constraint operator specified with the tilde character.
It behaves similarly to the operator of the same name in npm.

For example, specifying the version constraint as ~1.2.0 is functionally equivalent to >=1.2.0,<2.0.0. If the package adheres to the semantic versioning specification then any version in this range is guaranteed to be compatible.

@travisbot
Copy link

This pull request passes (merged cd96664 into 65e95ed).

@Seldaek
Copy link
Member

Seldaek commented Aug 2, 2012

Cool, fixes #643 partially too. If you'd like to work on the rest of those issues it'd be great :)

@stof
Copy link
Contributor

stof commented Aug 2, 2012

btw, the behavior described in this PR for ~1.2.0 does not match the behavior described in the issue.

@jmalloc
Copy link
Contributor Author

jmalloc commented Aug 3, 2012

@stof Are you referring to the fact that the normalised versions as used in the unit tests refer to ">1.1.999999.999999" instead of ">=1.2.0"? I did this for consistency with the existing wildcard operators, though now I fear I may have misunderstood the intent there.

@jmalloc
Copy link
Contributor Author

jmalloc commented Aug 3, 2012

@Seldaek I'll gladly take a look at #643, though I think I need to further my understanding of the normalised versions first :)

@ezzatron
Copy link

ezzatron commented Aug 3, 2012

@stof The functionality in this PR actually makes more sense with its treatment of semver. I added a more detailed comment on #643 to explain my point further.

@stof
Copy link
Contributor

stof commented Aug 3, 2012

@jmalloc no, I'm talking about the upper bound

@travisbot
Copy link

This pull request fails (merged e9d7125 into 65e95ed).

@travisbot
Copy link

This pull request fails (merged 5162b93 into 65e95ed).

@jmalloc
Copy link
Contributor Author

jmalloc commented Aug 6, 2012

Guys, I'll close this and re-open once all the features in #643 are complete.

@jmalloc jmalloc closed this Aug 6, 2012
@Seldaek
Copy link
Member

Seldaek commented Aug 9, 2012

As you wish, but if you don't have time to complete it please just reopen a PR with incomplete stuff, it's still better than nothing.

@jmalloc
Copy link
Contributor Author

jmalloc commented Aug 10, 2012

Oh, I'm definitely working on it - I have a few of the features complete, I just thought it was getting a bit noisy.

@Seldaek
Copy link
Member

Seldaek commented Sep 13, 2012

@jmalloc any news? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants