Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error checking that Process(...) actually worked #9808

Closed
ValtsS opened this issue Apr 3, 2021 · 2 comments
Closed

Missing error checking that Process(...) actually worked #9808

ValtsS opened this issue Apr 3, 2021 · 2 comments
Labels
Milestone

Comments

@ValtsS
Copy link

ValtsS commented Apr 3, 2021

$job['process'] = $process;

if process(..) failed then it fails down the line when tries to references job['process'] and does not find the key. Experienced on a PHP installation where certain functions are disabled.

@Seldaek Seldaek added this to the 2.0 milestone Apr 3, 2021
@Seldaek Seldaek added the Bug label Apr 3, 2021
@Seldaek
Copy link
Member

Seldaek commented May 20, 2021

I am not really sure how to reproduce the failure so am not 100% sure the fix is correct, but if you can check with the latest snapshot (composer self-update --snapshot) that would be great.

@ValtsS
Copy link
Author

ValtsS commented May 20, 2021

Seems to have worked:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants