Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The curl ... | php and php -r "eval(...);" install methods are scary #41

Closed
mkantor opened this issue Apr 17, 2013 · 4 comments
Closed

Comments

@mkantor
Copy link

mkantor commented Apr 17, 2013

What happens if getcomposer.org gets owned someday?

Recommending a safer install method might be worth considering. Others agree:

@Seldaek
Copy link
Member

Seldaek commented Apr 18, 2013

If the site is owned, what prevents attacker from placing insecure install instructions on the site? Or what prevents them from replacing the installer with something else? I mean no matter how "safe" the instructions, ultimately you'll end up executing some code coming from the server.

@mkantor
Copy link
Author

mkantor commented Apr 18, 2013

Nothing prevents them from changing the instructions, but the current command is copied hundreds of places (many still use the non-SSL variant) and this increases the community's vulnerability. Malicious changes to the installer are what I'm mostly concerned about.

no matter how "safe" the instructions, ultimately you'll end up executing some code coming from the server

Users will end up executing code from some server, but it could be signed code and it could come from a more trustable source. If the recommended way to install Composer was via PEAR (just an example) it'd get pulled off a server that likely has more security muscle behind it than getcomposer.org. Also you would be blame-free if something awful ever did happen 😇.

@sarciszewski
Copy link

If the site is owned, what prevents attacker from placing insecure install instructions on the site?

Asymmetric cryptographic signatures, unless the private key can also be compromised.

@mkantor
Copy link
Author

mkantor commented Apr 5, 2017

Seems like this has been taken care of at some point since I opened this ticket (eons ago).

@mkantor mkantor closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants