Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing image #10

Closed
petrleocompel opened this issue Sep 18, 2017 · 3 comments
Closed

Missing image #10

petrleocompel opened this issue Sep 18, 2017 · 3 comments
Labels

Comments

@petrleocompel
Copy link

Output is missing image what i should use
It's easy to reproduce.
Input

docker run -t --name="youtrack" uniplug/youtrack

Output

version: 3
services:
    youtrack: {}

Expected output

version: 3
services:
    youtrack:
        image: uniplug/youtrack
@magicmark
Copy link
Collaborator

Thanks for opening the issue! This is to do with how spawn-args treats arguments separated by = :(

> spawnargs('--a="b"', { removequotes: "always" })                                             
[ '--a=', 'b' ]                                 
> spawnargs('--a=b', { removequotes: "always" })                                               
[ '--a=b' ]     

This will be fixed by #12

@magicmark
Copy link
Collaborator

This should be now fixed :)

Let me know if you have any more issues!

@petrleocompel
Copy link
Author

petrleocompel commented Oct 18, 2017

Still it's not 100% ok.

Command

composerize docker run --name "postgis" -e POSTGRES_USER=app -e POSTGRES_PASS=app -e POSTGRES_DBNAME=elza12  -p 5432:5432 -d -t kartoza/postgis

Generates

version: 3
services:
    run:
        container_name: postgis
        environment:
            - POSTGRES_USER=app
            - POSTGRES_PASS=app
            - POSTGRES_DBNAME=elza12
        ports:
            - '5432:5432'
        image: run

Image is wrong -> run is not my image is docker command. Image is kartoza/postgis

But when you will delete -d -t it works. You should ignore -d, -t -i

So after deleting -d -t is my command this

composerize docker run --name "postgis" -e POSTGRES_USER=app -e POSTGRES_PASS=app -e POSTGRES_DBNAME=elza12  -p 5432:5432 kartoza/postgis

Generates

version: 3
services:
    postgis:
        container_name: postgis
        environment:
            - POSTGRES_USER=app
            - POSTGRES_PASS=app
            - POSTGRES_DBNAME=elza12
        ports:
            - '5432:5432'
        image: kartoza/postgis

And thats ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants