Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[N06] Lack of indexed parameters #400

Closed
cylon56 opened this issue Jun 15, 2022 · 1 comment
Closed

[N06] Lack of indexed parameters #400

cylon56 opened this issue Jun 15, 2022 · 1 comment
Assignees
@kevincheng96
Labels
openzeppelin PRs and issues related to OZ audit

Comments

@cylon56
Copy link

cylon56 commented Jun 15, 2022

The CometDeployed, GovernorTransferred, SetFactory, SetGovernor, SetPauseGuardian, SetBaseTokenPriceFeed, SetExtensionsDelegate events lack of any indexed parameter.

Consider indexing event parameters to avoid hindering the task of off-chain services searching and filtering for specific events.
@kevincheng96 kevincheng96 added the openzeppelin PRs and issues related to OZ audit label Jun 15, 2022
@kevincheng96 kevincheng96 self-assigned this Jun 16, 2022
@kevincheng96 kevincheng96 mentioned this issue Jun 16, 2022
Merged
@jflatow
Copy link
Contributor

jflatow commented Jul 1, 2022

We agree that these event parameters can be indexed to facilitate off-chain processing and have made the change.

@jflatow jflatow closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevincheng96 kevincheng96

Labels
openzeppelin PRs and issues related to OZ audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jflatow @kevincheng96 @cylon56