Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UniswapAnchoredView returns price for Zero address (0x00). #149

Open
akshaysrivastav opened this issue Jun 10, 2021 · 0 comments
Open

Comments

@akshaysrivastav
Copy link

Issue

The current oracle implementation that the Compound Protocol uses which is deployed at 0x4007B71e01424b2314c020fB0344b03A7C499E1A returns a price value from getUnderlyingPrice() function when the zero address (0x00) is passed.

This issue however does not break any compound protocol functionality but still getting a price value for an invalid input is not ideal.

Cause

The reason for this issue seems to be due to the addition of TokenConfig for LINK, KNC and SNX tokens. These three configs were added without a cToken address value.

Resolution

The getUnderlyingPrice() function should check the validity of the input address variable (input should not be equal to 0x00).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant