Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue route/component(s) for candidate #10

Closed
robrobbins opened this issue Jul 9, 2019 · 2 comments
Closed

Vue route/component(s) for candidate #10

robrobbins opened this issue Jul 9, 2019 · 2 comments
Assignees

Comments

@robrobbins
Copy link
Collaborator

There is an important distinction to make about candidates vs listings

  • any listing candidate is not an actual listing until it is voted "in"
  • any listing candidate is simply a candidate until it is voted "in"

Other candidates do exist:

  • reparam
  • challenge

Therefore a UI/UX decision must be made. Does the route ../candidate/hash and the route .../listing/hash show the same thing? Or do we choose to show nothing on the listing/hash for listings which are still in their applicant phase?

NOTE: Other candidates do not have the permanence that listings do. A challenge or reparam simply vanish when voting is done...

@ReidWilliams
Copy link
Contributor

My preference is to have one consistent route that works for both candidates and listings.

The page can render different elements depending on whether it's a candidate or a voted listing. A listing would have the option to buy, (and if the user is the owner, delete). A candidate would show the candidate metadata (title, description) but have some words that say that it is still a candidate and not allow buying.

The question is what is that route. Finding a candidate at .../listing/hash is abusing the nomenclature a bit. I'm fine with that for now.

@robrobbins
Copy link
Collaborator Author

there cannot be just one, that is restfully incorrect

that does not mean that .../listing/hash does not work for a candidate. sure it can - show the candidate stuff if a candidate, and show the listing stuff if not

there will be a .../candidate/hash route that works as well if it is still an applicant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants