Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify unspecified arguments None vs () #97

Closed
JorisVincent opened this issue Aug 8, 2023 · 0 comments
Closed

Unify unspecified arguments None vs () #97

JorisVincent opened this issue Aug 8, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JorisVincent
Copy link
Contributor

Observed behavior

Some functions can leave out arguments by specifying (explicit or implicit) None. For others, e.g. rings_generalized(target_indices=None) raises errors -- instead it expects ()` (or some other empty sequence).
This is confusing.

Expected behavior

In all cases where an argument is optional, it should accept None. In cases where () would work, both should work.

@JorisVincent JorisVincent added the bug Something isn't working label Aug 8, 2023
@JorisVincent JorisVincent self-assigned this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant