New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling of do_ftemp_kphio for C4 plants #19

Closed

davidorme opened this issue Feb 15, 2022 · 1 comment

Contributor

davidorme commented Feb 15, 2022

The values used here:

https://github.com/computationales/rpmodel/blob/master/R/subroutines.R#L358

ftemp = -0.008 + 0.00375 * tc - 0.58e-4 * tc^2

are incorrect. Shirley has pointed out that the values have been scaled twice in error and that these should be:

ftemp = -0.064 + 0.03 * tc - 0.000464 * tc^2

davidorme mentioned this issue

Set of bug fixes #18

Merged

Collaborator

stineb commented Feb 23, 2022

Thanks. I implemented this corrected parametrisation with commit d9177ee.

stineb closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment