Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for negative inflow to kinematic_wave #524

Open
kordejong opened this issue Dec 2, 2022 · 0 comments
Open

Add support for negative inflow to kinematic_wave #524

kordejong opened this issue Dec 2, 2022 · 0 comments

Comments

@kordejong
Copy link
Member

kordejong commented Dec 2, 2022

Lateral inflow represents the addition of water (e.g. precepitation), or removal of water (e.g. infiltration, pumping). Very comparable with accu_threshold. The outflow passed in (negative inflow) is a maximum / potential value and may be different from what is actually removed from the cell.

We could add a second return value containing the actual amount of water removed, given the actual amount of water available in each cell. Until then, it is impossible for users to check the water budget when less water is removed than potentially can be removed. See #527

Lateral inflow can be negative. Make sure the actual outflow (negative inflow) is not larger than the actual amount of water in the cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant