Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break up helper.py #25

Closed
logicabrity opened this issue Apr 28, 2016 · 1 comment
Closed

break up helper.py #25

logicabrity opened this issue Apr 28, 2016 · 1 comment
Labels
enhancement

Comments

@logicabrity
Copy link
Member

The file fidimag/fidimag/common/helper.py contains a series of unrelated functions. Some of them, like init_vector and init_scalar have been superseded by the functions in fidimag/common.field.py. What about the others?

Break this module up in more sensibly named ones.
@logicabrity logicabrity mentioned this issue Apr 28, 2016
Closed
@rpep
Copy link
Member

rpep commented Oct 1, 2018

This has changed a lot anyway; we Cythonised a lot of it to improve performance.

@rpep rpep closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@logicabrity @rpep