Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review before publishing #1

Open
Planeshifter opened this issue Jun 17, 2015 · 0 comments
Open

Code review before publishing #1

Planeshifter opened this issue Jun 17, 2015 · 0 comments

Comments

@Planeshifter
Copy link
Contributor

Open question:
I currently do not support a dtype option, since the output will always be an array or matrix consisting of only zeros and ones. If one does not use the copy option, I default to an underlying typed array of type int8. Is this a reasonable choice? If the user nonetheless wants to have an array of another type, he can just use the cast-arrays module anyway.

The same question applies to compute-io/isodd#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Planeshifter