Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: refactor createFormValidator #489

Closed
alee opened this issue Sep 25, 2019 · 1 comment · Fixed by #639
Closed

frontend: refactor createFormValidator #489

alee opened this issue Sep 25, 2019 · 1 comment · Fixed by #639

Comments

@alee
Copy link
Member

alee commented Sep 25, 2019

right now the createFormValidator works but is a bit of a convoluted mess that is possibly only understood by @cpritcha. We should see if there are better ways of abstracting its responsibilities:

  1. form validation
  2. others?
@alee
Copy link
Member Author

alee commented Sep 25, 2019

as a first step we probably need to just document it better so that we can figure out how to use it properly. I think we figured this out as needing to modify the yup() schema

overall https://github.com/jquense/yup is pretty nice, and the abstractions make sense after looking at it for a while but we should still figure out areas of clean where possible

@sgfost sgfost assigned sgfost and unassigned cpritcha and chrstngyn Mar 6, 2023
@sgfost sgfost linked a pull request Apr 20, 2023 that will close this issue
@sgfost sgfost closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants