Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#217][feat] add doppler.com variables include #220

Closed
wants to merge 1 commit into from
Closed

[#217][feat] add doppler.com variables include #220

wants to merge 1 commit into from

Conversation

icepuma
Copy link
Member

@icepuma icepuma commented Jul 25, 2022

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the motivation / use case for changing the behavior?

My feature contribution is all about having doppler.com secrets being variables in comtrya.

The schemas are:

  • doppler://<project>/<config>/<secret>
  • doppler://<project>/<config>

The code checks, if you're logged in or not.

@icepuma icepuma requested review from a team, rawkode and martintc and removed request for a team July 25, 2022 19:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #220 (b6baf95) into main (3fd0e90) will decrease coverage by 1.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   47.00%   45.80%   -1.21%     
==========================================
  Files          68       69       +1     
  Lines        2136     2192      +56     
==========================================
  Hits         1004     1004              
- Misses       1132     1188      +56     
Impacted Files Coverage Δ
lib/src/contexts/variable_include/doppler.rs 0.00% <0.00%> (ø)
lib/src/contexts/variable_include/mod.rs 33.33% <0.00%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd0e90...b6baf95. Read the comment docs.

@icepuma
Copy link
Member Author

icepuma commented Jul 25, 2022

Sorry for adding you 2 prematurely. I will add more stuff, before I will request your feedback.

@icepuma icepuma requested review from a team, rawkode and martintc and removed request for a team July 25, 2022 20:01
- supported schemas:
  - "doppler://<project>/<config>/<secret>" -> single secret
  - "doppler://<project>/<config>" -> all secrets for config

- secrets beginning with "DOPPLER_" will be filtered out
- the code checks if you're logged in or not
@icepuma icepuma marked this pull request as ready for review July 25, 2022 20:24
@icepuma
Copy link
Member Author

icepuma commented Jul 26, 2022

Any objections @rawkode or cool to merge?

@rawkode
Copy link
Member

rawkode commented Jul 27, 2022

@icepuma If you want to merge this as is, I am happy to do so.

I'm a little unsure about building up CLI executions as this enhancement does and I'm curious how we could integrate a bit more natively with the doppler API.

Why?

Well, it actually seems a bit nicer to use Doppler CLI natively with doppler run -- comtrya and use our ENV contexts instead of parsing the doppler secrets --json command.

I need to give this a little more thought. Perhaps something for our community call to gain more perspectives.

@icepuma
Copy link
Member Author

icepuma commented Jul 27, 2022

Let's discuss in our community call

@icepuma
Copy link
Member Author

icepuma commented Jul 28, 2022

Maybe DopplerHQ/cli#322 will solve my problem with wanting to have a tighter control over my secrets I want to use in a comtrya run.

With the implementation of my PR we could have multiple single secrets from multiple projects/configurations, which the doppler run - call doesn't support. But maybe this is okay if the user only wants to work with one tuple (project / config)

@rawkode
Copy link
Member

rawkode commented Jul 28, 2022

@icepuma As discussed, we're happy to close this for the time being?

@icepuma icepuma closed this Jul 28, 2022
@icepuma icepuma deleted the doppler branch July 28, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants