New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#217][feat] add doppler.com variables include #220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 47.00% 45.80% -1.21%
==========================================
Files 68 69 +1
Lines 2136 2192 +56
==========================================
Hits 1004 1004
- Misses 1132 1188 +56
Continue to review full report at Codecov.
|
Sorry for adding you 2 prematurely. I will add more stuff, before I will request your feedback. |
- supported schemas: - "doppler://<project>/<config>/<secret>" -> single secret - "doppler://<project>/<config>" -> all secrets for config - secrets beginning with "DOPPLER_" will be filtered out - the code checks if you're logged in or not
Any objections @rawkode or cool to merge? |
@icepuma If you want to merge this as is, I am happy to do so. I'm a little unsure about building up CLI executions as this enhancement does and I'm curious how we could integrate a bit more natively with the doppler API. Why? Well, it actually seems a bit nicer to use Doppler CLI natively with I need to give this a little more thought. Perhaps something for our community call to gain more perspectives. |
Let's discuss in our community call |
Maybe DopplerHQ/cli#322 will solve my problem with wanting to have a tighter control over my secrets I want to use in a With the implementation of my PR we could have multiple single secrets from multiple projects/configurations, which the |
@icepuma As discussed, we're happy to close this for the time being? |
I'm submitting a
What is the motivation / use case for changing the behavior?
My feature contribution is all about having doppler.com secrets being variables in comtrya.
The schemas are:
doppler://<project>/<config>/<secret>
doppler://<project>/<config>
The code checks, if you're logged in or not.