Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Generate correct version #13

Open
jeswr opened this issue Sep 23, 2022 · 2 comments
Open

Fix: Generate correct version #13

jeswr opened this issue Sep 23, 2022 · 2 comments

Comments

@jeswr
Copy link
Member

jeswr commented Sep 23, 2022

I suggest that the package.json's and be generated with a version number matching that of @comunica/core rather than v1.0.0

@rubensworks
Copy link
Member

That should already be the case: https://github.com/comunica/generate-comunica/blob/master/generators/common/props.js#L6

Isn't this working correctly for you?

@surilindur
Copy link
Contributor

The way I read the original comment, it seemed to refer to the version of the generated package itself, like here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants