Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to comunica v2 conventions #8

Closed
jeswr opened this issue Jan 18, 2022 · 2 comments
Closed

Update to comunica v2 conventions #8

jeswr opened this issue Jan 18, 2022 · 2 comments

Comments

@jeswr
Copy link
Member

jeswr commented Jan 18, 2022

For Bus's the template file should look something like:

import { Actor, IAction, IActorArgs, IActorOutput, IActorTest, Mediate } from '@comunica/core';

/**
 * <%= descriptionActor %>
 *
 * Actor types:
 * * Input:  IAction<%= componentBaseName %>:      TODO: fill in.
 * * Test:   <none>
 * * Output: IActor<%= componentBaseName %>Output: TODO: fill in.
 *
 * @see IAction<%= componentBaseName %>
 * @see IActor<%= componentBaseName %>Output
 */
export abstract class Actor<%= componentBaseName %> extends Actor<IAction<%= componentBaseName %>, IActorTest, IActor<%= componentBaseName %>Output> {
  public constructor(args: IActor<%= componentBaseName %>Args) {
    super(args);
  }
}

export interface IAction<%= componentBaseName %> extends IAction {

}

export interface IActor<%= componentBaseName %>Output extends IActorOutput {

}

export type IActor<%= componentBaseName %>Args = IActorArgs<IAction<%= componentBaseName %>, IActorTest, IActor<%= componentBaseName %>Output>

export type Mediator<%= componentBaseName %> = Mediate<IAction<%= componentBaseName %>, IActor<%= componentBaseName %>Output>

Happy to create a PR with this - if so, are there any other changes I should integrate at the same time?

@jeswr
Copy link
Member Author

jeswr commented Jan 18, 2022

Though probably best to wait for the release of the new comunica version first ...

@rubensworks
Copy link
Member

Indeed, the generators will have to be updated.
I still have some changes planned that might impact the template, so I would indeed wait a bit until those are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants