Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Test all functions #37

Closed
wschella opened this issue May 20, 2019 · 3 comments
Closed

Test all functions #37

wschella opened this issue May 20, 2019 · 3 comments
Labels
difficulty:challenging Implementing or fixing this will present a doable challenge priority:high test
Milestone

Comments

@wschella
Copy link
Member

The spec tests are very insufficient for testing all logic (certainly in regards to types) of all functions. For every function we should add a test ourselves.

@wschella wschella added difficulty:challenging Implementing or fixing this will present a doable challenge priority:high test labels May 20, 2019
@wschella wschella added this to the Fully tested milestone May 20, 2019
@Tpt Tpt mentioned this issue Jun 1, 2022
@jitsedesmet
Copy link
Member

I think this issue can be closed? Haven't checked manually, but I don't see how we could have got 100% coverage if we don't test all functions.

@wschella
Copy link
Member Author

wschella commented Sep 5, 2023

It originally meant better testing (for all functions). The fact that you have full coverage doesn't necessarily means you test all cases between interacting functions. And the spec tests don't cover much. That said, this issue is a bit too vague (and could thus be closed), but we should be aware there is room for more tests, especially w.r.t. typing logic.

@jitsedesmet
Copy link
Member

I agree. Better tests could be beneficial. However, since we can not test everything and I don't see any benefit in transferring this issue to Comunica, I will close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty:challenging Implementing or fixing this will present a doable challenge priority:high test
Projects
None yet
Development

No branches or pull requests

2 participants