Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added World Weather Online as a service, and a few minor tweaks #10

Merged
merged 5 commits into from Oct 13, 2014
Merged

Added World Weather Online as a service, and a few minor tweaks #10

merged 5 commits into from Oct 13, 2014

Conversation

sebj
Copy link
Contributor

@sebj sebj commented Oct 4, 2014

I added World Weather Online as an available weather service, and updated one or two comments to be more descriptive/correct. I made the changes a while ago, but forgot to create a pull request and all.

I've also merged the latest changes from your master branch back in, of course.

@sebj
Copy link
Contributor Author

sebj commented Oct 4, 2014

Also, the Travis build status is curious.. Looking at the log/details, everything seems to actually be fine with tests passing, except for some strange +[SimDeviceSet defaultSet]: unrecognized selector sent to class 0x10cb65280 message.

@comyar
Copy link
Owner

comyar commented Oct 8, 2014

Awesome! Let me look into the Travis build status...I'll merge as soon as possible.

comyar pushed a commit that referenced this pull request Oct 13, 2014
Added World Weather Online as a service, and a few minor tweaks
@comyar comyar merged commit 070b466 into comyar:master Oct 13, 2014
@comyar
Copy link
Owner

comyar commented Oct 13, 2014

So I don't think the tests are failing because of any code on our end, I think it may just have to do with xctool and Travis CI. I'm going to mess around with it and see if I can get the tests to pass. I went ahead and merged your changes.

Others are having the same issue here

@comyar
Copy link
Owner

comyar commented Oct 13, 2014

Alright, so I got the tests to pass by forcing Travis to update homebrew and build xctool from source before the tests. Check the .travis.yml if you're interested in seeing the changes.

@sebj
Copy link
Contributor Author

sebj commented Oct 13, 2014

Ah, wow. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants