New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddLocation search bar autocomplete bug #15
Comments
Thanks! I know what you mean, this really bugged me (and continues to bug me...) when I was working on the app. As far as I can tell, the issue is because of Apple's implementation of the back-end for CLGeocoder. The only fix I can think of is switching to a different service like Google's reverse geocoding API. I'm working on majorly refactoring the whole app at the moment, so I may switch over to using Google's API. In the meantime, if you find an easier fix, feel free to make a pull request. |
Yeh that makes sense, it does appear to be CLGeocoder. Google's api looks pretty solid. Also came across these as potential alternatives: |
I think I've settled on Google's API, it looks very simple and it has a high enough rate limit that I don't have to worry. API Page |
Sounds great Comyar. I've got a version working running this (which uses google api) https://github.com/spoletto/SPGooglePlacesAutocomplete The autocomplete results are definitely a lot better. However for some reason it has stopped displaying the background color on local and non-local weatherViews. Any idea what might cause that?? Apart from that it is working. I used cocoa pods to install SPGooglePlacesAutocomplete so guess it may be something to do with that, that is causing the backgroundcolor bug. Perhaps a clean implementation of google's api might be best way to go with it. |
Hmm that's an odd bug, not sure what could have caused it. That project doesn't look like it's being updated anymore and I tend to avoid using dead libraries in my project. I've started working on my own wrapper around Google's geocoder API, you can see it here. |
Alright, I wrote up a non-generalized solution to this here. Once I finish the work on my CZWeatherKit branch, it'll be included in the app. Thanks for bringing this up, I probably wouldn't have looked into it otherwise! |
Hey Comyar, great job with the app!
Have you come across a bug with the autocomplete suggestions in AddLocation search bar? It seems to have problems finding certain cities and suggests random locations for example, I typed in 'd' and it suggests 'Ronhert Park, CA' ?? No D's in there :)
Also certain major cities cannot be found but only some of the time. e.g. New York - sometimes it's suggested, sometimes not.
I'm having a look around for a fix and could submit a pull request if I find anything.
Are you able to reproduce this bug?
Any ideas what may be causing it?
The text was updated successfully, but these errors were encountered: