New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVD subtitle stream detection different if no title is specified #5
Comments
In the above examples, -analyzeduration/-probesize are required to detect all the subtitle streams. If I re-run the commands on each title separately, but w/o the -analyzeduration/-probesize options, the result is only 8 subtitle streams for both title 1 and 2. That matches the result for title 2 when no title is specified. Is it possible in the case where no title is specified (ie -i dvd://dvd/VIDEO_TS), the -analyzeduration/-probesize values are only getting applied to the first input (ie title=1)? |
I think that might be it. Take a look at this output:
Notice only title 1 is using the correct -analyzeduration/-probesize values. |
…-hls_segment_filename previously, specifying -hls_segment_filename meant s->base_output_dirname was never set, causing a segfault: (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0) * frame #0: 0x00007fffbf7d82d0 libsystem_platform.dylib`_platform_strcmp + 80 frame #1: 0x00000001005f4dcf libavformat.57.dylib`io_open_default(s=0x000000010481cc00, pb=0x0000000104806020, url=0x0000000000000000, flags=2, options=0x0000000000000000) at options.c:107 frame #2: 0x0000000100528968 libavformat.57.dylib`hls_mux_init(s=0x000000010481cc00) at hlsenc.c:595 frame #3: 0x00000001005273cb libavformat.57.dylib`hls_write_header(s=0x000000010481cc00) at hlsenc.c:1518 frame #4: 0x00000001005c08d0 libavformat.57.dylib`write_header_internal(s=0x000000010481cc00) at mux.c:486 frame #5: 0x00000001005c0774 libavformat.57.dylib`avformat_write_header(s=0x000000010481cc00, options=0x00000001029026e8) at mux.c:539
If vgtmpeg is run on a dvd/VIDEO_TS and the title is specified the number of subtitles detected may be different then when vgtmpeg is run without specifying a title.
Might be easier to see with an example. Here's a DVD with 3 subtitles. When vgtmpeg is run separately on each of the 3 titles, the number of subtitle streams is as follows:
vgtmpeg detects 12 subtitle streams for titles 1 and 2 and 2 subtitle streams for title 3.
If vgtmpeg is run without specifying a title:
It detects 12 subtitle streams for title 1 (as expected) and 2 for title 3 (as expected), but only 8 for title 2.
For comparison, here's the output from lsdvd:
A few things to note, although I don't know if these have anything to do with this issue:
This particular DVD exhibits the same subtitle doubling behavior identified in issue #4. So where lsdvd shows 6 subtitle streams for title 2, that corresponds to the 12 detected by vgtmpeg if you discount the duplicates.
lsdvd only shows 2 subtitle streams for title 1. The 4 subtitle streams missing are the 4 "Director" commentary streams and on this DVD, those streams are selected by going to the "Bonus" features.
Titles 1 and 2 are exactly the same length and in fact are exactly the same. I used mplayer -dumpstream to extract both title 1 and 2 and they are exactly the same:
$ sum -r title-1.vob title-2.vob
45060 6048958 title-1.vob
45060 6048958 title-2.vob
The text was updated successfully, but these errors were encountered: